Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15340
to look at the new patch set (#6).
Change subject: IMPALA-9430: always pass through kerberos configs
......................................................................
IMPALA-9430: always pass through kerberos configs
The behaviour of kerberos-related command line flags is changed so that
their values are always passed through to underlying libraries,
even if Kerberos isn't enabled for internal communication in Impala.
This is good because:
* Various libraries that communicate with external systems may use
kerberos for outgoing connections, if *incoming* connections are
not authenticated.
e.g. it might just be enabled for HMS. Having them pick up different
kerberos settings for outgoing connections if kerberos is disabled
for incoming connections is a little weird. This
is a safer default that reduces chances of inadvertant
misconfigurations.
* It matches the documentation of the flags.
Some validations are still disabled when --principal is not set,
e.g. we don't check the replay cache directory. This is to avoid
any potential regressions or startup failures on non-kerberised
clusters.
Testing:
Added unit tests for flag validation and env var setting on the
code paths that I touched.
Change-Id: If4bb311c7ab7173232aab36c5ed801f93f38f5b9
---
M be/src/common/global-flags.cc
M be/src/rpc/authentication.cc
M be/src/rpc/authentication.h
M be/src/rpc/rpc-mgr-kerberized-test.cc
4 files changed, 124 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/15340/6
--
To view, visit http://gerrit.cloudera.org:8080/15340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4bb311c7ab7173232aab36c5ed801f93f38f5b9
Gerrit-Change-Number: 15340
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
