Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15096 )
Change subject: IMPALA-9156: share broadcast join builds ...................................................................... Patch Set 10: (17 comments) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.h@444 PS10, Line 444: void IncrementNumSpilledProbeRows(int64_t count) { num_spilled_probe_rows_.Add(count); } line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@601 PS10, Line 601: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@603 PS10, Line 603: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@627 PS10, Line 627: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@629 PS10, Line 629: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@632 PS10, Line 632: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") transferring " << probe_reservation << " back to builder."; line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@712 PS10, Line 712: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") transferring " << probe_reservation << " back to builder."; line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@776 PS10, Line 776: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") transferring " << probe_reservation << " back to builder."; line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@940 PS10, Line 940: int64_t saved_probe_reservation = need_probe_buffer ? max_row_buffer_size_ * num_probe_threads_ : 0; line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@941 PS10, Line 941: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@944 PS10, Line 944: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@966 PS10, Line 966: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@969 PS10, Line 969: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") probe_stream_reservation_=" << probe_stream_reservation_.GetReservation(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/be/src/exec/partitioned-hash-join-builder.cc@1051 PS10, Line 1051: VLOG(3) << "PHJ(node_id=" << join_node_id_ << ") transferring " << bytes << " back to builder."; line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/15096/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@201 PS10, Line 201: DataStreamSink streamSink = new DataStreamSink((ExchangeNode)destNode_, outputPartition_); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@371 PS10, Line 371: // join. ParallelPlanner sets the destination fragment when adding the JoinBuildSink. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15096/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@400 PS10, Line 400: // join. ParallelPlanner sets the destination fragment when adding the JoinBuildSink. line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c67e4b2c87ed0fba648f1e1710addb885d66dc7 Gerrit-Change-Number: 15096 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 07 Mar 2020 00:45:40 +0000 Gerrit-HasComments: Yes
