Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15363 )
Change subject: IMPALA-5904: (part 3) Fix more TSAN bugs ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/rpc/hs2-http-test.cc File be/src/rpc/hs2-http-test.cc: http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/rpc/hs2-http-test.cc@37 PS1, Line 37: using namespace impala; > I think you can remove this now. Done http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/runtime/data-stream-test.cc@349 PS1, Line 349: void CreateTupleComparator(TupleRowComparator*& less_than_comparator) { > Pass by ** to keep consistent with coding conventions. Done http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/15363/1/be/src/runtime/descriptors.cc@617 PS1, Line 617: i++ > nit: ++i Done -- To view, visit http://gerrit.cloudera.org:8080/15363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 08 Mar 2020 17:49:04 +0000 Gerrit-HasComments: Yes
