Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/15371 )
Change subject: IMPALA-9429: Unioned partition columns break partition pruning ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15371/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15371/1//COMMIT_MSG@14 PS1, Line 14: surrounding code only handles specific cases. > I don't think that's quite what happens as the always True cases his the sa The reason that the one predicate case works is that the predicate that is used from pruning is the original expression that still contains the SlotRef and cannot be folded. The predicate that was marked constant and folded was a clone of the clone that was mapped to the InlineViewRef. Seems that we may have broader problems here tracking unassigned predicates that have undergone transformations. Perhaps we should try to isolate what change broke this? -- To view, visit http://gerrit.cloudera.org:8080/15371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c1384c2cd1ad5f7024449196f9a348ecdccb60b Gerrit-Change-Number: 15371 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 21:01:30 +0000 Gerrit-HasComments: Yes
