Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15391 )
Change subject: IMPALA-9446 Fix bug that impala failed to read zstd file on s3 ...................................................................... Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/15391/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15391/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9446 Fix bug that impala failed to read zstd file on s3 nit: I think the standard practice is to have a colon after the jira Id. http://gerrit.cloudera.org:8080/#/c/15391/1//COMMIT_MSG@9 PS1, Line 9: S3 filesystem doesn't have a block concept, so scheduler split each nit: split -> splits fixes this bug -> to add support for zstd. http://gerrit.cloudera.org:8080/#/c/15391/1//COMMIT_MSG@13 PS1, Line 13: Testing done: Would be good to validate the fix by running the failing tests in S3. http://gerrit.cloudera.org:8080/#/c/15391/1//COMMIT_MSG@14 PS1, Line 14: In mini-cluster, read external table locates on s3 zstd file. typo: locates->located -- To view, visit http://gerrit.cloudera.org:8080/15391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13f8837fda7454ddb4bb47d20a675d6315a3462d Gerrit-Change-Number: 15391 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2020 16:43:45 +0000 Gerrit-HasComments: Yes
