Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15412 )
Change subject: IMPALA-9350: Produce Ranger audits for column masking ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15412/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15412/1//COMMIT_MSG@17 PS1, Line 17: Testing: We should have some kind of automatic tests, e.g. in https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java http://gerrit.cloudera.org:8080/#/c/15412/1//COMMIT_MSG@20 PS1, Line 20: Solr Can you explain why Solr is relevant here? http://gerrit.cloudera.org:8080/#/c/15412/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15412/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@303 PS1, Line 303: RangerBufferAuditHandler auditHandler = (sqlStmt == null || hostname == null) ? null : : new RangerBufferAuditHandler(sqlStmt, plugin_.getClusterName(), hostname); An alternative to always creating a new audit handler is to create a AuthorizationContext member AnalyzesContext, which has its own audit handler, and pass it to createColumnMask. I don't know if performance matters here, but we could do a single flush that way. http://gerrit.cloudera.org:8080/#/c/15412/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@347 PS1, Line 347: nit: extra line -- To view, visit http://gerrit.cloudera.org:8080/15412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d8a1181234dcef580f68f56c24ad7e962cfe58e Gerrit-Change-Number: 15412 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2020 18:34:31 +0000 Gerrit-HasComments: Yes
