Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 )
Change subject: IMPALA-9357: Fix race condition in alter_database event ...................................................................... Patch Set 9: (2 comments) Updated the test changes to remove flakiness due to the way we execute async queries in sync_ddl mode. http://gerrit.cloudera.org:8080/#/c/15260/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/15260/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@850 PS8, Line 850: tryLockDb(db); > Do we need to check if lock successfully here? Good catch. I added a check here to throw an exception since you can't do much here if you can't get a lock on Db. By default it waits for 7200 sec which is a pretty long duration to try to get a lock. http://gerrit.cloudera.org:8080/#/c/15260/9/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/15260/9/tests/custom_cluster/test_concurrent_ddls.py@108 PS9, Line 108: " > flake8: E131 continuation line unaligned for hanging indent Done -- To view, visit http://gerrit.cloudera.org:8080/15260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I472fd8a55740769ee5cdb84e48422a4ab39a8d1e Gerrit-Change-Number: 15260 Gerrit-PatchSet: 9 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2020 20:02:19 +0000 Gerrit-HasComments: Yes
