Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode ...................................................................... Patch Set 1: (4 comments) Thanks very much for making the doc change. I left some comments to clarify. Please feel free to let me know if you have any questions. http://gerrit.cloudera.org:8080/#/c/15442/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/15442/1/docs/shared/impala_common.xml@a1525 PS1, Line 1525: : Just for my curiosity, why do we want to remove the video? I mean It still shows the effect of live_progress and live_summary. http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml File docs/topics/impala_live_progress.xml: http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml@a46 PS1, Line 46: : : This paragraph is still true when live_progress = True. We may still want to keep it? http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml@51 PS1, Line 51: <p> You can turn off <codeph>LIVE_PROGRESS</codeph> within the shell : using the <codeph>SET</codeph> command. </p> IMPALA-9384 also proposed a new command line flag "--disable_live_progress". The flag allows users to disable live_progress in the runtime. e.g. run impala shell with "bin/impala-shell.sh --disable_live_progress" then live_progress will be disable in the interactive mode. In addition, setting live_progress = false in the config file is another way to disable the shell option. http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_shell_options.xml File docs/topics/impala_shell_options.xml: http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_shell_options.xml@a532 PS1, Line 532: : : : : : : we still want to keep this right? as --live_progress is still an impala shell option. We may also want to add --disable_live_progress. // for --live_progress <row> <entry>--live_progress</entry> <entry>live_progress=true</entry> <entry>Prints a progress bar .....</entry> </row> // for --disable_live_progress <row> <entry>--disable_live_progress</entry> <entry>live_progress=false</entry> <entry>A command line flag allows users to disable live_progress in the interactive mode.</entry> </row> -- To view, visit http://gerrit.cloudera.org:8080/15442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf Gerrit-Change-Number: 15442 Gerrit-PatchSet: 1 Gerrit-Owner: Kristine Hahn <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2020 01:27:50 +0000 Gerrit-HasComments: Yes
