Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15451 )
Change subject: IMPALA-9029: [DOCS] Impala 3.4 Release Notes ...................................................................... Patch Set 1: Two things: 1. Can we add a line to impala_new_features.xml saying that we added support for ZSTD and DEFLATE compression codecs for text files? 2. From a git perspective, this is using a pattern that I'm not used to. We use cherrypicks rather than merge commands. Here's how I would like the change to proceed: - Cherrypick Alex's original change on top of current master branch (see dropdown "Download" on the right side and copy the cherrypick command). For me the command is: git fetch ssh://[email protected]:29418/Impala-ASF refs/changes/63/14863/1 && git cherry-pick FETCH_HEAD - Make your changes on top of it. Do git add / git commit, then "git rebase origin/master -i" and fixup your new commit with Alex's original commit. Reword the commit message if needed. Leave the Change-Id the same. - Then upload that to gerrit with "git push --no-thin asf-gerrit HEAD:refs/for/master". That should do an upload to Alex's original review. If any of that doesn't make sense, reach out to me and I can help you through it. -- To view, visit http://gerrit.cloudera.org:8080/15451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31e9fcc1e1aa98c784b2c597a6df5aeb75be44c5 Gerrit-Change-Number: 15451 Gerrit-PatchSet: 1 Gerrit-Owner: Kristine Hahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2020 22:34:18 +0000 Gerrit-HasComments: No
