Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/15465 )
Change subject: Add support for centos8 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15465/1/docker/all/postinstall.sh File docker/all/postinstall.sh: http://gerrit.cloudera.org:8080/#/c/15465/1/docker/all/postinstall.sh@31 PS1, Line 31: alternatives --set python /usr/bin/python2 > Just a question: does this alias pip2 to pip as well? Kinda. pip doesn't get installed through the OS packages. It gets installed on line 39 of this script. Since it gets called using python2, we end up with pip running under python2.7 (os dependent). So basically: dnf install python2 python3 <snip> # which python which: no python in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin) # which pip which: no pip in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin) # alternatives --set python /usr/bin/python2 # which python /usr/bin/python # which pip which: no pip in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin) # python get-pip.py # which pip /usr/bin/pip http://gerrit.cloudera.org:8080/#/c/15465/1/docker/redhat8.df File docker/redhat8.df: http://gerrit.cloudera.org:8080/#/c/15465/1/docker/redhat8.df@48 PS1, Line 48: RUN postinstall.sh : : COPY ./all > nit: I guess this comment is stale now Done -- To view, visit http://gerrit.cloudera.org:8080/15465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc15c202f61e251761fd0b1dc9aa0b15c27b3363 Gerrit-Change-Number: 15465 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2020 22:49:44 +0000 Gerrit-HasComments: Yes
