Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15306 )
Change subject: IMPALA-8690: Add LIRS cache eviction algorithm ...................................................................... Patch Set 17: (2 comments) still going through the lirs-cache code, but posted the comments i have so far http://gerrit.cloudera.org:8080/#/c/15306/17/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/15306/17/be/src/util/cache/lirs-cache.cc@166 PS17, Line 166: CAS what does this stand for? compare-and-swap? http://gerrit.cloudera.org:8080/#/c/15306/17/be/src/util/cache/lirs-cache.cc@202 PS17, Line 202: // TODO: Switch back to std library atomics when this works. do we have a JIRA for this? -- To view, visit http://gerrit.cloudera.org:8080/15306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I670fa4b2b7c93998130dc4e8b2546bb93e9a84f8 Gerrit-Change-Number: 15306 Gerrit-PatchSet: 17 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 01:05:38 +0000 Gerrit-HasComments: Yes
