Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )
Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete ...................................................................... Patch Set 4: (2 comments) Thanks for adding me, it is looks better now. Noticed a style change and 2 tables left where the formatting is not correct at the moment, these are related with the style change. I can see that <varname> was replaced with '<' and '>' in some places. In general <varname> is used to describe variables in Impala documentation, although there are few cases where there are '<' and '>'. I think we should go with the <varname> tags. These are the two commands that I used to check which annotation is used to mark variables, should be executed in this directory: 'Impala/docs/topics' grep -n "<.*>" ./* grep -n "<varname>.*</varname>" ./* http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml@292 PS4, Line 292: ------------------- The <varname> tags are translated to italic, therefore the extra dashes are not needed on this table. http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml@831 PS4, Line 831: ------ Because the < and > are displayed as < and > in the browser, this header should be 6 dashes shorter. -- To view, visit http://gerrit.cloudera.org:8080/15476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308 Gerrit-Change-Number: 15476 Gerrit-PatchSet: 4 Gerrit-Owner: Kristine Hahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 09:40:27 +0000 Gerrit-HasComments: Yes
