Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15487 )
Change subject: IMPALA-3343: Part 1 -- Fix simple python 2->3 syntax errors ...................................................................... IMPALA-3343: Part 1 -- Fix simple python 2->3 syntax errors In an effort to keep the work of reviewing the changes more manageable with regard to making the impala-shell python3 compatible, I'm trying to break the patches up into smaller chunks. The first patch is the easiest one -- simply addressing the handful of syntax issues that aren't python 3 compatible, namely changing the print statements to function calls, changing the way we catch exceptions, and adding a few simple branches to work around the removal of such things as dict.iteritems(). We needed the print function imported from __future__ because it allows us to pass in a file descriptor, e.g., sys.stderr. Notably, there's nothing in this patch related to string/bytes/unicode changes from python 2 to 3. Change-Id: I9a515da01ef03d5936cb1a4d9e4bc6d105386b1d Reviewed-on: http://gerrit.cloudera.org:8080/15487 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M shell/TSSLSocketWithWildcardSAN.py M shell/impala_client.py M shell/impala_shell.py M shell/option_parser.py M shell/pkg_resources.py M shell/shell_output.py 6 files changed, 243 insertions(+), 203 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9a515da01ef03d5936cb1a4d9e4bc6d105386b1d Gerrit-Change-Number: 15487 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
