Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15454 )
Change subject: IMPALA-3766: optionally compress spilled data ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/bufferpool/buffer-pool-test.cc@1628 PS7, Line 1628: void BufferPoolTest::TestTmpFileAllocateError(const string& compression, bool punch_holes) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr-test.cc File be/src/runtime/tmp-file-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr-test.cc@531 PS7, Line 531: int64_t expected_bytes_allocated = punch_holes ? 0 : expected_scratch_bytes_allocated; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr-test.cc@750 PS7, Line 750: ASSERT_OK(tmp_file_mgr.InitCustom(tmp_dir_specs, false, "", punch_holes, metrics_.get())); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr-test.cc@998 PS7, Line 998: file_group.Read(uncompressed_handle.get(), MemRange(big_tmp.data(), big_tmp.size()))); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/15454/7/be/src/runtime/tmp-file-mgr.cc@780 PS7, Line 780: VLOG(3) << "Write " << tmp_file->path() << " " << file_offset << " " << buffer_to_write.len(); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c08ff9504097f0fee8c32316c5c150136abe659 Gerrit-Change-Number: 15454 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Sat, 21 Mar 2020 17:35:21 +0000 Gerrit-HasComments: Yes
