Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15497 )
Change subject: IMPALA-8005: Randomize partitioning exchanges. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15497/3/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/15497/3/be/src/runtime/data-stream-test.cc@742 PS3, Line 742: ASSERT_EQ(result, true); > Agreed, we should have a more deterministic way to test this. Any thoughts? It depends on what the core purpose of the test is. I am wondering if it is really necessary to check if the receiver is different for a particular row across 2 queries, since this depends on the result of (hash_value % num_receivers). Since num_receivers is constant across 2 queries, what if we simplified the test to only check if the hash value is different for a row on the sender side. Given a random seed, the hash value for some number (say a BIGINT number) should in high likelihood be different across 2 queries. In the rare case it is not, you could just do the check in a loop 5 times. I am open to other suggestions.. -- To view, visit http://gerrit.cloudera.org:8080/15497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1936e6cc3e8d66420a5a9301f49221ca38f3e468 Gerrit-Change-Number: 15497 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Sun, 22 Mar 2020 03:33:30 +0000 Gerrit-HasComments: Yes
