Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15363 )
Change subject: IMPALA-5904: (part 3) Fix more TSAN bugs ...................................................................... Patch Set 4: Okay, I think this is in a working state now. @Tim if you could take another look at the changes to descriptors.h and descriptors.cc that would be great. In short, TSAN was reporting a race condition on setting the value of 'llvm_field_idx_' in TupleDescriptor::GetLlvmStruct. After taking a closer look, it looks like 'llvm_field_idx_' is always equal to 'slot_idx_' so I just replaced it with 'slot_idx_' instead. I added a DCHECK as well to ensure this. I ran exhaustive tests with TSAN disabled, and be tests with TSAN enabled. Both test runs pass. Pre-commit passes as well. -- To view, visit http://gerrit.cloudera.org:8080/15363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2020 22:07:39 +0000 Gerrit-HasComments: No
