Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15537 )
Change subject: Add timestamp to maven logging options. ...................................................................... Patch Set 1: (4 comments) Please verify that https://github.com/apache/impala/blob/master/bin/jenkins/get_maven_statistics.sh still works on this new output. I think it should. It didn't make any real assumptions about the timestamps. http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG@7 PS1, Line 7: Add timestamp to maven logging options. I think we can re-use IMPALA-9107 as the jira. http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG@9 PS1, Line 9: We found that using awk to add a timestamp to the maven log can fail : if gawk is not installed. It seems better to configure maven to add : the timestamp itself. Please add a small snippet of what the maven output looks like with a timestamp. http://gerrit.cloudera.org:8080/#/c/15537/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/15537/1/bin/impala-config.sh@328 PS1, Line 328: export IMPALA_MAVEN_OPTIONS="-U \ : -Dorg.slf4j.simpleLogger.showDateTime=true \ : -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss" We set IMPALA_MAVEN_OPTIONS in the environment to allow different settings for different automated jobs, so we should respect the environment version. (We can prepend the logging args so you have "${IMPALA_MAVEN_OPTIONS-} -Dorg.slf4j... etc etc") We don't always need -U, so we should avoid it if we can. http://gerrit.cloudera.org:8080/#/c/15537/1/bin/mvn-quiet.sh File bin/mvn-quiet.sh: http://gerrit.cloudera.org:8080/#/c/15537/1/bin/mvn-quiet.sh@35 PS1, Line 35: if ! mvn $IMPALA_MAVEN_OPTIONS "$@" | \ Keep the -B -- To view, visit http://gerrit.cloudera.org:8080/15537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10fbe9eb76b66e6ba00db9f95c91063410dd1b4e Gerrit-Change-Number: 15537 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2020 22:21:22 +0000 Gerrit-HasComments: Yes
