Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15541 )

Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................


Patch Set 1:

(23 comments)

http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793:  # IMPALA-9547: retry accept(). This is required in Python < 3.5 
because some
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793:  # IMPALA-9547: retry accept(). This is required in Python < 3.5 
because some
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793:  # IMPALA-9547: retry accept(). This is required in Python < 3.5 
because some
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@794
PS1, Line 794:  # EINTR return calls from syscalls are not automatically 
retried. See PEP475.
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@794
PS1, Line 794:  # EINTR return calls from syscalls are not automatically 
retried. See PEP475.
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@795
PS1, Line 795:  while True:
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@795
PS1, Line 795:  while True:
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796:    try:
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796:
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796:    try:
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797:      connection, client_address = sock.accept()
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797:
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797:      connection, client_address = sock.accept()
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@798
PS1, Line 798:             break
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799:    except IOError, e:
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799:    except IOError, e:
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799:    except IOError, e:
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800:      if e.errno != errno.EINTR:
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800:
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800:      if e.errno != errno.EINTR:
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801:        raise
flake8: W191 indentation contains tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801:
flake8: E101 indentation contains mixed spaces and tabs


http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801:        raise
tab used for whitespace



--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 24 Mar 2020 04:12:32 +0000
Gerrit-HasComments: Yes

Reply via email to