Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15473 )
Change subject: IMPALA-8533: Impala daemon crash on sort ...................................................................... IMPALA-8533: Impala daemon crash on sort This crash was caused by an empty sort tuple descriptor that was generated as a result of union substitutions replacing all sort fields with literals that were subsequently removed from the ordering spec. There was no check in place to prevent the empty tuple descriptor from being sent to impalad where it caused a divide-by-zero crash. Fix: This fix avoids inserting a sort node when there are no fields remaining to sort on. Also added a precondition to the SortNode that will prevent similar issues from crashing impalad. Testing: Testcases added to PlannerTest/union.test Change-Id: If19303fbf55927c1e1b76b9b22ab354322b21c54 Reviewed-on: http://gerrit.cloudera.org:8080/15473 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java M fe/src/main/java/org/apache/impala/planner/SortNode.java M testdata/workloads/functional-planner/queries/PlannerTest/union.test 3 files changed, 279 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If19303fbf55927c1e1b76b9b22ab354322b21c54 Gerrit-Change-Number: 15473 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
