David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 )
Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15524/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15524/4//COMMIT_MSG@121 PS4, Line 121: processes. > I'm running into an issue where if I run the packaged shell with python3, s It's true -- I actually had one more JIRA filed for that: https://issues.apache.org/jira/browse/IMPALA-9362 It is weird that the pip-installed version doesn't have this issue: $ impala-shell Starting Impala with no authentication using Python 3.7.6 <-- note version Opened TCP connection to localhost:21000 Connected to localhost:21000 Server version: impalad version 3.4.0-SNAPSHOT DEBUG (build cc91c...) *********************************************************************************** Welcome to the Impala shell. (Impala Shell v3.4.0-SNAPSHOT (cc91c66) built on Tue Mar 24 09:54:50 PDT 2020) The SET command shows the current value of all shell and query options. *********************************************************************************** [localhost:21000] default> http://gerrit.cloudera.org:8080/#/c/15524/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15524/4/shell/impala_shell.py@1790 PS4, Line 1790: if isinstance(options.output_delimiter, str): > This seems to barf if I pass in a unicode delimiter. I don't think this is Ah, interesting. I guess I was just working from our existing test cases -- I guess we don't have one for this. We can try to resolve it if you think it's important. http://gerrit.cloudera.org:8080/#/c/15524/4/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/15524/4/shell/make_shell_tarball.sh@52 PS4, Line 52: if [ "${USE_THRIFT11_GEN_PY:-}" == "false" ]; then > Does it make sense to allow overriding this? Would a shell built with old t Actually, that's a good point. Other tests pass, but unicode-related tests don't. We should probably disallow this. http://gerrit.cloudera.org:8080/#/c/15524/4/shell/make_shell_tarball.sh@53 PS4, Line 53: # thrift 0.9.3-p7 > Not sure if we need this comment? Ack -- To view, visit http://gerrit.cloudera.org:8080/15524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615 Gerrit-Change-Number: 15524 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2020 06:28:27 +0000 Gerrit-HasComments: Yes
