Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15454 )

Change subject: IMPALA-3766: optionally compress spilled data
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15454/9/be/src/runtime/bufferpool/buffer-pool-counters.h
File be/src/runtime/bufferpool/buffer-pool-counters.h:

http://gerrit.cloudera.org:8080/#/c/15454/9/be/src/runtime/bufferpool/buffer-pool-counters.h@59
PS9, Line 59:   RuntimeProfile::Counter* uncompressed_bytes_written;
> That's a good point. This is a per-operator counter versus a per-backend co
I think adding the timers makes a lot of sense.
For uncompressed bytes counter, I'm not sure. I could go either way. It looks 
like most "Buffer pool" counters are exposed per-operator, and are then 
aggregated in the per-backend profiles ("Per Node Profiles")?
I agree its probably not super useful to understand the compression ratio 
per-operator.


http://gerrit.cloudera.org:8080/#/c/15454/9/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/15454/9/be/src/runtime/tmp-file-mgr.cc@63
PS9, Line 63: d) Limit on the total bytes of compressio
> Updated the comment to explain (I think that's what you were getting at, ri
yeah updated docs for this flag look good, thanks



--
To view, visit http://gerrit.cloudera.org:8080/15454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c08ff9504097f0fee8c32316c5c150136abe659
Gerrit-Change-Number: 15454
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 16:12:22 +0000
Gerrit-HasComments: Yes

Reply via email to