Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15214 )

Change subject: IMPALA-8870: Bump up Guava to 28.1-jre and set DISABLE_SENTRY 
to true
......................................................................


Patch Set 11:

(1 comment)

There is only one failing test and it is caused by the change.

http://gerrit.cloudera.org:8080/#/c/15214/11/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java:

http://gerrit.cloudera.org:8080/#/c/15214/11/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@765
PS11, Line 765:     hasher.putString(queryStr, Charset.forName("UTF-8"));
We investigated the failed test with Fang-Yu and it is caused by returning 
different hash values here after the change, see 
https://stackoverflow.com/questions/21287714/hashing-issue-between-guava-versions/21291270#21291270



--
To view, visit http://gerrit.cloudera.org:8080/15214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68
Gerrit-Change-Number: 15214
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 18:19:49 +0000
Gerrit-HasComments: Yes

Reply via email to