Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15552 )

Change subject: IMPALA-9401: primitive include-what-you-use script and mappings
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15552/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15552/1//COMMIT_MSG@12
PS1, Line 12: build
> nit: may be a typo?
Done


http://gerrit.cloudera.org:8080/#/c/15552/1/bin/iwyu/iwyu.sh
File bin/iwyu/iwyu.sh:

http://gerrit.cloudera.org:8080/#/c/15552/1/bin/iwyu/iwyu.sh@31
PS1, Line 31:   echo ""
> Maybe add an example invocation with environment variables filled out based
Done



--
To view, visit http://gerrit.cloudera.org:8080/15552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf5f9ba865313afb0c581e6482514ef7f1c65367
Gerrit-Change-Number: 15552
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Thu, 26 Mar 2020 23:13:54 +0000
Gerrit-HasComments: Yes

Reply via email to