Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 )
Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. ...................................................................... Patch Set 5: (1 comment) Patch Set 5 submitted. What is different from Patch Set 4 is that now we can do single pass insert both in HashTable::Insert and HashTable::Iterator::SetTuple. Right now, this patch is hijacking the FLAGS_enable_quadratic_probing to enable robin hood mode rather than the quadratic probing mode. I plan to create separate flag for robin hood mode in next iteration, so that we can do performance comparison between linear, quadratic, and robin hood linear probe. http://gerrit.cloudera.org:8080/#/c/15511/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15511/3//COMMIT_MSG@14 PS3, Line 14: If a hash table is configured as a robin hood hash table, the new > I'm still thinking how to do single pass insert. From what I understand, we This is now addressed in Patch Set 5. -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 28 Mar 2020 04:48:28 +0000 Gerrit-HasComments: Yes
