Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )
Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly ...................................................................... Patch Set 2: (2 comments) I have a couple of small linguistic suggestions, otherwise this looks good. http://gerrit.cloudera.org:8080/#/c/15607/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15607/2//COMMIT_MSG@10 PS2, Line 10: randomly fails with function unknown error. For example, Nit: randomly fail when trying to find the function. For example," http://gerrit.cloudera.org:8080/#/c/15607/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/15607/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@494 PS2, Line 494: + ". Currently this db has function number " + db.numFunctions()); Slighly clearer: ". Currently this db has " + db.numFunctions() + " functions."); -- To view, visit http://gerrit.cloudera.org:8080/15607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9 Gerrit-Change-Number: 15607 Gerrit-PatchSet: 2 Gerrit-Owner: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Mar 2020 00:57:40 +0000 Gerrit-HasComments: Yes
