Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15545 )
Change subject: IMPALA-9099: allow mt_dop for joins without feature flag ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15545/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test: http://gerrit.cloudera.org:8080/#/c/15545/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test@3 PS3, Line 3: # IMPALA-9099: mt_dop is now allowed for joins, so we should run with mt_dop. : select min(l_orderkey), min(p_name) : from tpch.lineitem join tpch.part on l_partkey = p_partkey; : ---- RESULTS : 1,'almond antique blue royal burnished' : ---- TYPES : BIGINT,STRING : ---- RUNTIME_PROFILE : row_regex:.*Query Options \(set by configuration and planner\):.*MT_DOP=4.* : ==== : ---- QUERY : # IMPALA-9099: mt_dop is now allowed for joins, so we should run with mt_dop. : select min(l_orderkey), min(p_name) : from tpch_kudu.lineitem join tpch_kudu.part on l_partkey = p_partkey; : ---- RESULTS : 1,'almond antique blue royal burnished' : ---- TYPES : BIGINT,STRING : ---- RUNTIME_PROFILE : row_regex:.*Query Options \(set by configuration and planner\):.*MT_DOP=4.* > should we remove these and add equivalent tests (if they dont exist) to mt- I figured I would leave these here for now to reflect the changed behaviour, then we can remove the test entirely once the fallback codepaths are all removed. -- To view, visit http://gerrit.cloudera.org:8080/15545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c6566abb239db0e775f2beaa25a62c36313cd6f Gerrit-Change-Number: 15545 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2020 01:40:36 +0000 Gerrit-HasComments: Yes
