Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15604 )
Change subject: IMPALA-9568: Template tuples are initialized multiple times ...................................................................... IMPALA-9568: Template tuples are initialized multiple times Template tuples are initialized multiple times, concurrently, which leads to a data race reported by TSAN. The template tuples should just be initialized once. This patch removes the template tuple initialization done in the HDFS scanners and just copies them from the HdfsScanNodeBase. After this patch, data-load is now TSAN clean. I removed the TSAN flag 'halt_on_error=0' so that TSAN now crashes the process if a TSAN bug is discovered. This will allow us to setup a Jenkins job that runs dataload + be/ tests, and will crash if any new TSAN bugs are discovered. Testing: * Ran exhaustive tests Change-Id: I3bd3554b2b919b117a0c9ae86dfc0a75ae4129d2 Reviewed-on: http://gerrit.cloudera.org:8080/15604 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/init.cc M be/src/exec/hdfs-scanner.cc M bin/run-backend-tests.sh 3 files changed, 9 insertions(+), 18 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3bd3554b2b919b117a0c9ae86dfc0a75ae4129d2 Gerrit-Change-Number: 15604 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
