Hello Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15538

to look at the new patch set (#2).

Change subject: IMPALA-9537: Add LDAP auth to the webui
......................................................................

IMPALA-9537: Add LDAP auth to the webui

This patch adds a startup flag --webserver_require_ldap, which if set
to true secures the debug webserver with LDAP username/password
authentication.

It also adds the flags --webserver_ldap_group_filter and
--webserver_ldap_user_filter, which allow users to restrict access to
the webserver separately from the restrictions on other endpoints
(i.e. --ldap_group_filter and --ldap_user_filter), for example to
enable webserver access only for admin users.

Testing:
- Added a FE test that runs a custom cluster with ldap webserver auth
  enabled and verifies it works as expected, with and without filters
  specified.

Change-Id: I6e92481929f2f06898b8496233ab4134792c9f10
---
M be/src/util/webserver.cc
M be/src/util/webserver.h
M common/thrift/metrics.json
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
A fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M fe/src/test/java/org/apache/impala/util/Metrics.java
M tests/common/impala_service.py
8 files changed, 442 insertions(+), 99 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/15538/2
--
To view, visit http://gerrit.cloudera.org:8080/15538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e92481929f2f06898b8496233ab4134792c9f10
Gerrit-Change-Number: 15538
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to