Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15621 )
Change subject: IMPALA-9584: remove flaky avg(TIMESTAMP) aggregates from test_analytic_fns ...................................................................... IMPALA-9584: remove flaky avg(TIMESTAMP) aggregates from test_analytic_fns AVG(TIMESTAMP) is not deterministic, because it uses a double to sum the timestamps, and adding doubles in different order can lead to different results. This does not cause problems for DOUBLE columns, because the test framework does not require exact match if the result is double. As AVG is the only function for TIMESTAMP with this problem, reducing the precision of all timestamps checks seemed like an overkill. As a short term solution I removed the problematic aggregates from the tests. Testing: - ran only the related tests Change-Id: I10e0027a64a4e430b7db3ed7c8d0cc8cdcb202e0 Reviewed-on: http://gerrit.cloudera.org:8080/15621 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test 1 file changed, 34 insertions(+), 63 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10e0027a64a4e430b7db3ed7c8d0cc8cdcb202e0 Gerrit-Change-Number: 15621 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
