Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/14197/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/16//COMMIT_MSG@50 PS16, Line 50: IMPALA-9580 > IMPALA-9581 Done http://gerrit.cloudera.org:8080/#/c/14197/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14197/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@389 PS16, Line 389: null > Should this be a non-null value? The null case is tested above Done -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2020 01:37:40 +0000 Gerrit-HasComments: Yes
