Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 )
Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions ...................................................................... Patch Set 14: (28 comments) http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/bloom-filter.h@212 PS14, Line 212: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/bloom-filter.h@221 PS14, Line 221: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h File be/src/util/sse2neon.h: http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@548 PS14, Line 548: (vcombine_s32(vld1_s32((int32_t const *) p), vcreate_s32(0))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@1519 PS14, Line 1519: // Since the widening shifts would be rather confusing to follow in little endian, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3056 PS14, Line 3056: (vzip1q_s8(vreinterpretq_s8_m128i(a), vreinterpretq_s8_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3082 PS14, Line 3082: (vzip1q_s16(vreinterpretq_s16_m128i(a), vreinterpretq_s16_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3104 PS14, Line 3104: (vzip1q_s32(vreinterpretq_s32_m128i(a), vreinterpretq_s32_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3133 PS14, Line 3133: (vzip1q_f32(vreinterpretq_f32_m128(a), vreinterpretq_f32_m128(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3155 PS14, Line 3155: (vzip2q_f32(vreinterpretq_f32_m128(a), vreinterpretq_f32_m128(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3180 PS14, Line 3180: (vzip2q_s8(vreinterpretq_s8_m128i(a), vreinterpretq_s8_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3208 PS14, Line 3208: (vzip2q_s16(vreinterpretq_s16_m128i(a), vreinterpretq_s16_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3224 PS14, Line 3224: (vzip2q_s32(vreinterpretq_s32_m128i(a), vreinterpretq_s32_m128i(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3350 PS14, Line 3350: uint8x16_t k48_32 = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3351 PS14, Line 3351: vcombine_u8(vcreate_u8(0x0000ffffffffffff), vcreate_u8(0x00000000ffffffff)); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3352 PS14, Line 3352: uint8x16_t k16_00 = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3353 PS14, Line 3353: vcombine_u8(vcreate_u8(0x000000000000ffff), vcreate_u8(0x0000000000000000)); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3373 PS14, Line 3373: (vzip1q_u64(vreinterpretq_u64_u8(l), vreinterpretq_u64_u8(m))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3375 PS14, Line 3375: (vzip2q_u64(vreinterpretq_u64_u8(l), vreinterpretq_u64_u8(m))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3377 PS14, Line 3377: (vzip1q_u64(vreinterpretq_u64_u8(n), vreinterpretq_u64_u8(k))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3379 PS14, Line 3379: (vzip2q_u64(vreinterpretq_u64_u8(n), vreinterpretq_u64_u8(k))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3401 PS14, Line 3401: (vuzp1q_u64(vreinterpretq_u64_u8(t0t1_l), vreinterpretq_u64_u8(t0t1_h))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3403 PS14, Line 3403: (vuzp2q_u64(vreinterpretq_u64_u8(t0t1_l), vreinterpretq_u64_u8(t0t1_h))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3405 PS14, Line 3405: (vuzp1q_u64(vreinterpretq_u64_u8(t2t3_l), vreinterpretq_u64_u8(t2t3_h))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3407 PS14, Line 3407: (vuzp2q_u64(vreinterpretq_u64_u8(t2t3_l), vreinterpretq_u64_u8(t2t3_h))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3435 PS14, Line 3435: (_sse2neon_vmull_p64(vget_low_u64(a), vget_low_u64(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3437 PS14, Line 3437: (_sse2neon_vmull_p64(vget_high_u64(a), vget_low_u64(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3439 PS14, Line 3439: (_sse2neon_vmull_p64(vget_low_u64(a), vget_high_u64(b))); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15531/14/be/src/util/sse2neon.h@3441 PS14, Line 3441: (_sse2neon_vmull_p64(vget_high_u64(a), vget_high_u64(b))); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Apr 2020 10:16:05 +0000 Gerrit-HasComments: Yes
