Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 )
Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/15630/5/be/src/gutil/CMakeLists.txt File be/src/gutil/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15630/5/be/src/gutil/CMakeLists.txt@56 PS5, Line 56: MATCHES nit: does STREQUALS work? MATCHES is a regex match but I don't think we need a regex. http://gerrit.cloudera.org:8080/#/c/15630/5/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15630/5/be/src/service/CMakeLists.txt@67 PS5, Line 67: libclang_rt.ubsan_standalone_cxx-aarch64.a nit: use a variable for just the architecture, instead of duplicating the whole code block -- To view, visit http://gerrit.cloudera.org:8080/15630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d Gerrit-Change-Number: 15630 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2020 17:29:32 +0000 Gerrit-HasComments: Yes
