Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15672 )
Change subject: IMPALA-9611: fix hang when cancelling join builder ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15672/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: http://gerrit.cloudera.org:8080/#/c/15672/1/be/src/runtime/runtime-state.h@202 PS1, Line 202: /// The condition variable must have query lifetime. nit: Note: Make sure the caller thread checks for cancellation while holding the 'mutex' to avoid race condition. http://gerrit.cloudera.org:8080/#/c/15672/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: http://gerrit.cloudera.org:8080/#/c/15672/1/be/src/runtime/runtime-state.cc@234 PS1, Line 234: // writing thread (e.g. IMPALA-9611). Drop it before signalling the CV so that a nit: since is_cancelled_ is read while holding the lock -- To view, visit http://gerrit.cloudera.org:8080/15672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I996ad2055d6542eb57e12c663b89de5f84208f77 Gerrit-Change-Number: 15672 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2020 18:39:56 +0000 Gerrit-HasComments: Yes
