Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh File jenkins/build.sh: http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@21 PS1, Line 21: # the extension '.df' This defaults to All, right? http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@26 PS1, Line 26: resutling resulting http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@43 PS1, Line 43: impala-toolchain-* nit: I think this should probably be quoted, otherwise it could be expanded by bash to match any files in the current directory -- To view, visit http://gerrit.cloudera.org:8080/15675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55 Gerrit-Change-Number: 15675 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 20:32:25 +0000 Gerrit-HasComments: Yes
