Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 )
Change subject: IMPALA-9629: Add CentOS 8.1 support to bootstrap_system.sh ...................................................................... Patch Set 12: > Patch Set 12: Code-Review+2 > > (1 comment) The concerns are perfectly valid, and I don't consider this patch to be the ideal solution either. The way I see it it's a manageable first step that enables Impala on Centos8 without regressing on platforms already supported. As such, it opens the way for further improvements, but as with every first step, there are caveats. I also assume (maybe wrongly) that any developer moving to CentOS 8 will be exposed to the Python version dilemma anyway; CentOS (or RedHat) essentially ensured that they can't away from it. They will be aware of the problem, and they would (hopefully) be able to manage it. With that said, I also agree that nailing down the default version of Python is a pretty drastic step; I just hope that follow-up steps will quickly resolve the issues with the Python scripts so that we can get rid of this limitation. As for the scripts and their default environments: I tend to group them into two categories (loosely): - scripts performing some function inside the Impala dev environment, which are reasonably coupled to the Impala virtualenv. - scripts that would be nice to execute without an long setup process, even in a freshly cloned repo. An good example would be https://github.com/apache/impala/blob/master/docker/test-with-docker.py#L21, where we state this explicitly; bootstrap_toolchain.py is another good example. Ideally these scripts could run either with Python2 or Python3, or they should be tied explicitly to one of the major versions. I have already filed IMPALA-9627 (with you on cc:) to improve the utility scripts to be able to let people choose their Python version freely -- maybe that would be a better place to continue the discussion about the details. -- To view, visit http://gerrit.cloudera.org:8080/15623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e Gerrit-Change-Number: 15623 Gerrit-PatchSet: 12 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Apr 2020 13:03:28 +0000 Gerrit-HasComments: No
