Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14494
to look at the new patch set (#16).
Change subject: IMPALA-3926: part 2: avoid setting LD_LIBRARY_PATH
......................................................................
IMPALA-3926: part 2: avoid setting LD_LIBRARY_PATH
This removes LD_LIBRARY_PATH and LD_PRELOAD from the
developer's shell and cleans it up. With the preceding
change, toolchain utilities like clang can be run without
a special LD_LIBRARY_PATH.
Impala binaries don't have the rpath baked in for all
of the JVM and GCC libraries, so we still need to set
LD_LIBRARY_PATH when running those. That is solved
with wrapper scripts that sets the environment variables
only when invoking those binaries, e.g. starting a
daemon or running a backend test. I added three scripts
because there were 3 sets of environment variables. The
scripts are:
* run-binary.sh: just sets LD_LIBRARY_PATH
* run-jvm-binary.sh: sets LD_LIBRARY_PATH and CLASSPATH
* start-daemon.sh: sets LD_LIBRARY_PATH and CLASSPATH and
kerberos-related environment variables.
An alternative solution would be to add rpaths to
all binaries we build. I decided to avoid this
because we don't necessarily want random rpaths
from our dev environment to be present in output
artifacts.
An alternative to the 3 scripts would be to have an
uber-script that set all the variables, but I felt
that it was better to be specific about what
each binary needed. Cleaning the LD_LIBRARY_PATH
mess up has given me a distaste for scattershot
setting of environment variables. I am open to
revisiting this.
This patch does have some consequences for
development: workflows that involved running
built executables directly need to be modified
to prefix those calls with run-binary.sh or
a different wrapper script. The developer
can get the old behaviour back by sourcing
set-ld-library-path.sh in their shell, but
this is not recommended.
Testing:
* Ran tests on centos 7
* Manually tested that my dev env with
LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu continued
to work (for now). All ubuntu 16.04 and 18.04 dev
envs that were set up with bootstrap_development.sh
will be in this state.
Change-Id: I61c83e6cca6debb87a12135e58ee501244bc9603
---
M be/CMakeLists.txt
M bin/gen-backend-test-script.py
M bin/impala-config.sh
M bin/impala-python-common.sh
A bin/run-binary.sh
A bin/run-jvm-binary.sh
A bin/set-ld-library-path.sh
M bin/start-daemon.sh
M bin/validate-unified-backend-test-filters.py
M fe/pom.xml
M tests/query_test/test_insert_parquet.py
11 files changed, 136 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/14494/16
--
To view, visit http://gerrit.cloudera.org:8080/14494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61c83e6cca6debb87a12135e58ee501244bc9603
Gerrit-Change-Number: 14494
Gerrit-PatchSet: 16
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
