Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13993 )
Change subject: IMPALA-8834: Short-circuit partition key scan ...................................................................... Patch Set 13: (6 comments) http://gerrit.cloudera.org:8080/#/c/13993/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/13993/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java@69 PS13, Line 69: // The caller passes in a MultiAggregateInfo to the constructor that this scan node uses to line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13993/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java@71 PS13, Line 71: // applied to the MultiAggregateInfo in this query block. We do not apply the smap in this line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13993/13/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/13993/13/tests/query_test/test_queries.py@246 PS13, Line 246: class TestPartitionKeyScans(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13993/13/tests/query_test/test_queries.py@254 PS13, Line 254: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/13993/13/tests/query_test/test_queries.py@257 PS13, Line 257: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/13993/13/tests/query_test/test_queries.py@257 PS13, Line 257: : flake8: E231 missing whitespace after ':' -- To view, visit http://gerrit.cloudera.org:8080/13993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c87525a4f75ffeb654267b89948653b2e1ff8c Gerrit-Change-Number: 13993 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 20 Apr 2020 19:22:43 +0000 Gerrit-HasComments: Yes
