Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image ...................................................................... Patch Set 2: Code-Review+2 (1 comment) LGTM http://gerrit.cloudera.org:8080/#/c/15765/2/docker/impala_base/Dockerfile File docker/impala_base/Dockerfile: http://gerrit.cloudera.org:8080/#/c/15765/2/docker/impala_base/Dockerfile@17 PS2, Line 17: ARG BASE_IMAGE=ubuntu:16.04 Can this default value ever be used now that we expect BASE_IMAGE to be always set as in the docker invocation? -- To view, visit http://gerrit.cloudera.org:8080/15765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df Gerrit-Change-Number: 15765 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 21 Apr 2020 23:51:15 +0000 Gerrit-HasComments: Yes
