Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15702 )
Change subject: IMPALA-9639 [DOCS] Document Impala support for Kudu DATE type ...................................................................... Patch Set 1: (3 comments) Hi Kristine, thank you for this change. I only had 2 minor comments and 1 nit. http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml File docs/topics/impala_date.xml: http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@44 PS1, Line 44: <p> Use the <codeph>DATE</codeph> data type to store date values. The : <codeph>DATE</codeph> type is supported for HBase, Text, Avro, and : Parquet. </p> We should add Kudu to this list as well. http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@200 PS1, Line 200: nit: empty space before newline http://gerrit.cloudera.org:8080/#/c/15702/1/docs/topics/impala_date.xml@203 PS1, Line 203: For example:</p> : <p> : <codeblock> : create table kudu_date_key (fdatekey date primary key, val string) : stored as kudu : insert into kudu_date_key values (DATE '1970-01-01', 'Unix epoch'), (DATE '2019-12-12', 'today') : </codeblock> I could not find any difference between Kudu and non-Kudu Date type usage, also non-Kudu usage is not documented. So I think this example is not needed here. -- To view, visit http://gerrit.cloudera.org:8080/15702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865599587817358b0c94debfcb0e9644fab4ae00 Gerrit-Change-Number: 15702 Gerrit-PatchSet: 1 Gerrit-Owner: Kristine Hahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 22 Apr 2020 09:14:46 +0000 Gerrit-HasComments: Yes
