Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15783
to look at the new patch set (#2).
Change subject: IMPALA-9685: Fix ACID tables missing row__id column in
LocalCatalog mode
......................................................................
IMPALA-9685: Fix ACID tables missing row__id column in LocalCatalog mode
In catalog server, when extracting the schema of a full ACID table from
the HMS table meta, we insert the synthetic "row__id" column. We need to
do the same thing in LocalCatalog mode coordinators, because they don't
fetch the loaded schema from catalog server. Instead, they fetch the HMS
table meta and extract the schema again.
Tests:
- Run test_acid.py in local catalog mode.
- Add a canary test in test_local_catalog.py. It can be removed once we
enable local catalog mode by default.
Change-Id: Ieb11e520325908e2e33a257568e15637d66c9901
---
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M tests/custom_cluster/test_local_catalog.py
8 files changed, 57 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15783/2
--
To view, visit http://gerrit.cloudera.org:8080/15783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb11e520325908e2e33a257568e15637d66c9901
Gerrit-Change-Number: 15783
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
