Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@143 PS2, Line 143: List<IcebergPartitionSpec> getIcebergPartitionSpecs() { return tableDef_.getIcebergPartitionSpecs(); } line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@565 PS2, Line 565: throw new AnalysisException("Invalid storage handler specified for Iceberg format: " + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java@37 PS2, Line 37: public IcebergPartitionField(int fieldId, String fieldName, TIcebergPartitionType fieldType) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java File fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java@33 PS2, Line 33: List<KuduPartitionParam> partitionParams, List<IcebergPartitionSpec> icebergPartitionSpecs) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java@51 PS2, Line 51: return new TableDataLayout(new ArrayList<>(), new ArrayList<>(), icebergPartitionSpecs); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@61 PS2, Line 61: resultSchema.addToColumns(new TColumn("Field Partition Type", Type.STRING.toThrift())); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@96 PS2, Line 96: return isIcebergStorageHandler(msTbl.getParameters().get(KuduTable.KEY_STORAGE_HANDLER)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@198 PS2, Line 198: cols.add(new FieldSchema(column.name(), colType.toSql().toLowerCase(), column.doc())); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@245 PS2, Line 245: public TTableDescriptor toThriftDescriptor(int tableId, Set<Long> referencedPartitions) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@50 PS2, Line 50: static LocalTable loadFromIceberg(LocalDb db, Table msTable, MetaProvider.TableMetaRef ref) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@65 PS2, Line 65: List<IcebergPartitionSpec> partitionSpecs = Utils.loadPartitionSpecByIceberg(metadata); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@79 PS2, Line 79: fieldSchemas.add(new FieldSchema(column.name(), colType.toSql().toLowerCase(), column.doc())); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@84 PS2, Line 84: private LocalIcebergTable(LocalDb db, Table msTable, MetaProvider.TableMetaRef ref, ColumnMap cmap, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@102 PS2, Line 102: public TTableDescriptor toThriftDescriptor(int tableId, Set<Long> referencedPartitions) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2244 PS2, Line 2244: else if (IcebergTable.isIcebergTable(tbl)) return createIcebergTable(tbl, params, response); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2570 PS2, Line 2570: Types.NestedField.optional(4, "call_stack", Types.ListType.ofRequired(5, Types.StringType.get())) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2577 PS2, Line 2577: PartitionSpec.builderFor(getTestSchema()).hour("event_time").identity("level").build(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@51 PS2, Line 51: tables.create(schema, IcebergUtil.createIcebergPartition(schema, params), metadataLoc); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@70 PS2, Line 70: public static PartitionSpec createIcebergPartition(Schema schema, TCreateTableParams params) line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@73 PS2, Line 73: List<TIcebergPartitionField> partitionFields = params.getPartition_spec().getPartition_fields(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15797/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@114 PS2, Line 114: throw new TableLoadingException("Unsupported iceberg partition type: " + field.transform()); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 02:28:33 +0000 Gerrit-HasComments: Yes
