Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15761 )
Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download ...................................................................... Patch Set 3: (1 comment) LGTM basically, one q about making it stricter, but I'm OK with this as-is. http://gerrit.cloudera.org:8080/#/c/15761/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15761/3/fe/pom.xml@755 PS3, Line 755: <exclude>io.netty:netty-all:4.1.42.Final</exclude> Can we tighten this up to exclude everything from io.netty? I.e. io.netty:* . It seems like we're excluding it all anyway (at least I don't see it when I run (cd fe && mvn dependency:tree -Dscope=runtime) with USE_CDP_HIVE=true -- To view, visit http://gerrit.cloudera.org:8080/15761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69bc84eaa692e78988cff06bb1b7e5fd2a0bb774 Gerrit-Change-Number: 15761 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 06:57:54 +0000 Gerrit-HasComments: Yes
