Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15818 )

Change subject: IMPALA-9512: Full ACID Milestone 2: Validate each row against 
the valid write id list
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15818/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/15818/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@269
PS1, Line 269:      * TODO(boroknagyz): rename or remove
TODO: resolve this TODO


http://gerrit.cloudera.org:8080/#/c/15818/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/15818/1/testdata/bin/generate-schema-statements.py@663
PS1, Line 663:       print "file_format=", file_format
             :       print "create_file_format=", create_file_format
TODO: delete these


http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/impala_test_suite.py@620
PS1, Line 620:       print "TEST_SECTION", test_section
TODO: delete this



--
To view, visit http://gerrit.cloudera.org:8080/15818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d
Gerrit-Change-Number: 15818
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 28 Apr 2020 09:23:46 +0000
Gerrit-HasComments: Yes

Reply via email to