Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 )
Change subject: IMPALA-9679: Remove some jars from Docker images ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15753/5/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15753/5/fe/pom.xml@1309 PS5, Line 1309: <version>${knox.version}</version> : <exclusions> : <!-- Impala currently doesn't support GCS, so exclude those jars --> : <exclusion> : <groupId>c > I looked around, and I think gateway-cloud-bindings needs some classes from I see what you mean. I really mainly objected to this transitively pulling in groovy (we don't need to ship a whole language runtime!). I don't think the cloud bindings require groovy, so this seems safer. -- To view, visit http://gerrit.cloudera.org:8080/15753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030e7cd28e29cd4e077c0b4addd4d14a8599eed6 Gerrit-Change-Number: 15753 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Apr 2020 23:38:37 +0000 Gerrit-HasComments: Yes
