Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15831 )
Change subject: IMPALA-9686: Add readline to Python ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15831/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15831/2//COMMIT_MSG@21 PS2, Line 21: Runtime asserts were also added to the Python build driver for the Which were these? Can we add something like we added for fastbinary in the thread build.sh to make sure that the module can be imported? -- To view, visit http://gerrit.cloudera.org:8080/15831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbe6fa16305a4462278306947535fad468cb3d8 Gerrit-Change-Number: 15831 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2020 04:06:08 +0000 Gerrit-HasComments: Yes
