Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15822 )
Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf ...................................................................... Patch Set 1: (1 comment) looked through the rest of the review, skimmed most of the changes since they mostly look like straightforward re-factoring lgtm pending comments http://gerrit.cloudera.org:8080/#/c/15822/1/be/src/scheduling/cluster-membership-test-util.h File be/src/scheduling/cluster-membership-test-util.h: http://gerrit.cloudera.org:8080/#/c/15822/1/be/src/scheduling/cluster-membership-test-util.h@20 PS1, Line 20: #include "gen-cpp/StatestoreService_types.h" still needed? -- To view, visit http://gerrit.cloudera.org:8080/15822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d1e373d9c87887144517ff6a4c2d5996aa88b8 Gerrit-Change-Number: 15822 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 30 Apr 2020 00:43:14 +0000 Gerrit-HasComments: Yes
