Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 )
Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15796/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15796/7//COMMIT_MSG@18 PS7, Line 18: Furthermore, to avoid compilation errors related to the absense of shiro, it : was necessary to remove the TestSentryResourceAuthorizationProvider class, : and any tests that referenced it. There are some end-to-end tests that reference TestSentryResourceAuthorizationProvider: authorization/test_authorization.py authorization/test_grant_revoke.py authorization/test_owner_privileges.py authorization/test_sentry.py authorization/test_show_grant.py They are disabled, because we have Sentry tests disabled. Sentry support is already broken. I'm thinking about whether we should do anything about them in this change. -- To view, visit http://gerrit.cloudera.org:8080/15796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f9994bf81c1d2e025a03925e8eccb147c34d66e Gerrit-Change-Number: 15796 Gerrit-PatchSet: 7 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 01 May 2020 18:43:21 +0000 Gerrit-HasComments: Yes
