Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15818 )

Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the 
valid write id list
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15818/3/be/src/exec/acid-metadata-utils.cc
File be/src/exec/acid-metadata-utils.cc:

http://gerrit.cloudera.org:8080/#/c/15818/3/be/src/exec/acid-metadata-utils.cc@60
PS3, Line 60: ;
initialize it


http://gerrit.cloudera.org:8080/#/c/15818/3/testdata/workloads/functional-query/queries/QueryTest/acid-negative.test
File testdata/workloads/functional-query/queries/QueryTest/acid-negative.test:

http://gerrit.cloudera.org:8080/#/c/15818/3/testdata/workloads/functional-query/queries/QueryTest/acid-negative.test@70
PS3, Line 70: # We can't issue REFRESH here because REFRESH only works if the 
metadata for the table
            : # is successfully loaded. The previous REFRESH broke table 
metadata. Once Impala-9042 is
            : # resolved everything should work smoothly.
            : invalidate metadata acid;
use REFRESH acid here



--
To view, visit http://gerrit.cloudera.org:8080/15818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d
Gerrit-Change-Number: 15818
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 05 May 2020 08:06:48 +0000
Gerrit-HasComments: Yes

Reply via email to