Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15822 )
Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf ...................................................................... IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf The new admission control service will be written in protobuf, so there are various admission control related structures currently stored in Thrift that it would be convenient to convert to protobuf, to minimize the amount of converting back and forth that needs to be done. This patch converts TBackendDescriptor to protobuf. It isn't used directly in any rpcs - we serialize it ourselves to send to the statestore as a string, so no rpc definitions are affected. This patch is just a refactor and doesn't contain any functional changes. Testing: - Passed a full run of existing tests. Change-Id: Ie7d1e373d9c87887144517ff6a4c2d5996aa88b8 Reviewed-on: http://gerrit.cloudera.org:8080/15822 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/global-types.h M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/cluster-membership-mgr-test.cc M be/src/scheduling/cluster-membership-mgr.cc M be/src/scheduling/cluster-membership-mgr.h M be/src/scheduling/cluster-membership-test-util.cc M be/src/scheduling/cluster-membership-test-util.h M be/src/scheduling/executor-blacklist.cc M be/src/scheduling/executor-blacklist.h M be/src/scheduling/executor-group.cc M be/src/scheduling/executor-group.h M be/src/scheduling/query-schedule.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler-test-util.cc M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h M be/src/service/cancellation-work.h M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/statestore/CMakeLists.txt M be/src/util/container-util.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M be/src/util/network-util.cc M be/src/util/network-util.h M be/src/util/uid-util.h M be/src/util/unique-id-hash.h M common/protobuf/CMakeLists.txt A common/protobuf/statestore_service.proto M common/thrift/StatestoreService.thrift 38 files changed, 621 insertions(+), 495 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie7d1e373d9c87887144517ff6a4c2d5996aa88b8 Gerrit-Change-Number: 15822 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
