Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG@7 PS1, Line 7: Fix formatting of HBaseScanNode explain output. > Since this is not an urgent hot-fix, could you create a JIRA for this? Done http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@591 PS1, Line 591: + "'" + filter.filter_constant + "'" > nit: could you move this to the previous line? Agreed will do, but this was the formatted enforced by clang-format. -- To view, visit http://gerrit.cloudera.org:8080/15749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567 Gerrit-Change-Number: 15749 Gerrit-PatchSet: 1 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2020 22:40:47 +0000 Gerrit-HasComments: Yes
